feat: add 0x swap data #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janndriessen
commented
May 24, 2024
| @@ -71,14 +70,13 @@ export class FlashMintQuoteProvider | |||
| { | |||
| constructor( | |||
| private readonly provider: JsonRpcProvider, | |||
| private readonly swapQuoteProvider?: SwapQuoteProvider, | |||
| private readonly zeroExApiV1?: ZeroExApi | |||
| private readonly swapQuoteProvider: SwapQuoteProvider | |||
There was a problem hiding this comment.
- adds
swapQuoteProvideras required dependency - removes
zeroExApiV1as dependency
janndriessen
commented
May 24, 2024
| if (contractType === FlashMintContractType.leveraged) return true | ||
| if (contractType === FlashMintContractType.leveragedExtended) return true | ||
| return false | ||
| } |
There was a problem hiding this comment.
obsolete as the swap quote provider is always required
0xonramp
approved these changes
May 24, 2024
feat: add v3
feat: use rpc url
feat: remove 0x utils
janndriessen
merged commit 0b9f943
into
feat/add-swap-quote-provider-protocol
1 check failed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #58